CVE-2024-45774.patch 1.4 KB

12345678910111213141516171819202122232425262728293031323334353637
  1. From 2c34af908ebf4856051ed29e46d88abd2b20387f Mon Sep 17 00:00:00 2001
  2. From: Daniel Axtens <dja@axtens.net>
  3. Date: Fri, 8 Mar 2024 22:47:20 +1100
  4. Subject: [PATCH] video/readers/jpeg: Do not permit duplicate SOF0 markers in
  5. JPEG
  6. Otherwise a subsequent header could change the height and width
  7. allowing future OOB writes.
  8. Fixes: CVE-2024-45774
  9. Reported-by: Nils Langius <nils@langius.de>
  10. Signed-off-by: Daniel Axtens <dja@axtens.net>
  11. Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
  12. CVE: CVE-2024-45774
  13. Upstream-Status: Backport [https://git.savannah.gnu.org/cgit/grub.git/commit/?id=2c34af908ebf4856051ed29e46d88abd2b20387f]
  14. Signed-off-by: Peter Marko <peter.marko@siemens.com>
  15. ---
  16. grub-core/video/readers/jpeg.c | 4 ++++
  17. 1 file changed, 4 insertions(+)
  18. diff --git a/grub-core/video/readers/jpeg.c b/grub-core/video/readers/jpeg.c
  19. index ae634fd41..631a89356 100644
  20. --- a/grub-core/video/readers/jpeg.c
  21. +++ b/grub-core/video/readers/jpeg.c
  22. @@ -339,6 +339,10 @@ grub_jpeg_decode_sof (struct grub_jpeg_data *data)
  23. if (grub_errno != GRUB_ERR_NONE)
  24. return grub_errno;
  25. + if (data->image_height != 0 || data->image_width != 0)
  26. + return grub_error (GRUB_ERR_BAD_FILE_TYPE,
  27. + "jpeg: cannot have duplicate SOF0 markers");
  28. +
  29. if (grub_jpeg_get_byte (data) != 8)
  30. return grub_error (GRUB_ERR_BAD_FILE_TYPE,
  31. "jpeg: only 8-bit precision is supported");