CVE-2024-45783.patch 1.3 KB

123456789101112131415161718192021222324252627282930313233343536373839404142
  1. From f7c070a2e28dfab7137db0739fb8db1dc02d8898 Mon Sep 17 00:00:00 2001
  2. From: B Horn <b@horn.uk>
  3. Date: Sun, 12 May 2024 06:22:51 +0100
  4. Subject: [PATCH] fs/hfsplus: Set a grub_errno if mount fails
  5. It was possible for mount to fail but not set grub_errno. This led to
  6. a possible double decrement of the module reference count if the NULL
  7. page was mapped.
  8. Fixing in general as a similar bug was fixed in commit 61b13c187
  9. (fs/hfsplus: Set grub_errno to prevent NULL pointer access) and there
  10. are likely more variants around.
  11. Fixes: CVE-2024-45783
  12. Reported-by: B Horn <b@horn.uk>
  13. Signed-off-by: B Horn <b@horn.uk>
  14. Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
  15. CVE: CVE-2024-45783
  16. Upstream-Status: Backport [https://git.savannah.gnu.org/cgit/grub.git/commit/?id=f7c070a2e28dfab7137db0739fb8db1dc02d8898]
  17. Signed-off-by: Hitendra Prajapati <hprajapati@mvista.com>
  18. ---
  19. grub-core/fs/hfsplus.c | 2 +-
  20. 1 file changed, 1 insertion(+), 1 deletion(-)
  21. diff --git a/grub-core/fs/hfsplus.c b/grub-core/fs/hfsplus.c
  22. index 19c7b33..e7fd98a 100644
  23. --- a/grub-core/fs/hfsplus.c
  24. +++ b/grub-core/fs/hfsplus.c
  25. @@ -393,7 +393,7 @@ grub_hfsplus_mount (grub_disk_t disk)
  26. fail:
  27. - if (grub_errno == GRUB_ERR_OUT_OF_RANGE)
  28. + if (grub_errno == GRUB_ERR_OUT_OF_RANGE || grub_errno == GRUB_ERR_NONE)
  29. grub_error (GRUB_ERR_BAD_FS, "not a HFS+ filesystem");
  30. grub_free (data);
  31. --
  32. 2.25.1