CVE-2024-45782_CVE-2024-56737.patch 1.3 KB

123456789101112131415161718192021222324252627282930313233343536
  1. From 417547c10410b714e43f08f74137c24015f8f4c3 Mon Sep 17 00:00:00 2001
  2. From: B Horn <b@horn.uk>
  3. Date: Sun, 12 May 2024 02:48:33 +0100
  4. Subject: [PATCH] fs/hfs: Fix stack OOB write with grub_strcpy()
  5. Replaced with grub_strlcpy().
  6. Fixes: CVE-2024-45782
  7. Fixes: CVE-2024-56737
  8. Fixes: https://savannah.gnu.org/bugs/?66599
  9. Reported-by: B Horn <b@horn.uk>
  10. Signed-off-by: B Horn <b@horn.uk>
  11. Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
  12. CVE: CVE-2024-45782
  13. CVE: CVE-2024-56737
  14. Upstream-Status: Backport [https://git.savannah.gnu.org/cgit/grub.git/commit/?id=417547c10410b714e43f08f74137c24015f8f4c3]
  15. Signed-off-by: Peter Marko <peter.marko@siemens.com>
  16. ---
  17. grub-core/fs/hfs.c | 2 +-
  18. 1 file changed, 1 insertion(+), 1 deletion(-)
  19. diff --git a/grub-core/fs/hfs.c b/grub-core/fs/hfs.c
  20. index 91dc0e69c..920112b03 100644
  21. --- a/grub-core/fs/hfs.c
  22. +++ b/grub-core/fs/hfs.c
  23. @@ -379,7 +379,7 @@ grub_hfs_mount (grub_disk_t disk)
  24. volume name. */
  25. key.parent_dir = grub_cpu_to_be32_compile_time (1);
  26. key.strlen = data->sblock.volname[0];
  27. - grub_strcpy ((char *) key.str, (char *) (data->sblock.volname + 1));
  28. + grub_strlcpy ((char *) key.str, (char *) (data->sblock.volname + 1), sizeof (key.str));
  29. if (grub_hfs_find_node (data, (char *) &key, data->cat_root,
  30. 0, (char *) &dir, sizeof (dir)) == 0)